On 21/04/2023 22:51, Maxim Kochetkov wrote: > > > On 21.04.2023 23:41, Krzysztof Kozlowski wrote: >> On 21/04/2023 22:01, Maxim Kochetkov wrote: >>> There is no way to select max98088 from menuconfig right now. >>> Add a Kconfig menu description to allow building the driver standalone. >> >> Just like many other codecs used in embedded designs. Why exactly this >> one should be user selectable, but others not? > > I can tell nothing about any other codecs. But this one has no external > dependencies. I just need to enable it and assign DT node to bring it > up. So we can let them be user selectable. Why your sound-card cannot select it? IOW, what is so different in your design from existing upstream sound cards and choices? Commit should answer to "why" you are doing it and in current Linux sources I do not see the need for it to be user-selectable. Commit msg does not explain it either. Best regards, Krzysztof