On Fri, 21 Apr 2023 17:25:46 +0200, Oswald Buddenhagen wrote: > > On Fri, Apr 21, 2023 at 05:14:10PM +0200, Takashi Iwai wrote: > > On Fri, 21 Apr 2023 16:10:02 +0200, > > Oswald Buddenhagen wrote: > >> > >> Signed-off-by: Oswald Buddenhagen <oswald.buddenhagen@xxxxxx> > > > > No changelog is no good news. > > Please give more information. > > > i suppose this is a difference in philosophy. i generally refrain from > covering in the commit message what comments in the patch already > explain. otherwise it would be just redundant, and i don't like that > very much. > > anyway, i can add some speculation what problems this could have > theoretically caused. You didn't explain exactly *WHAT* you fixed, and that's the readers may be interested more. The summary says merely "fix snd_emu1010_fpga_read() input masking for rev2 cards". What was broken beforehand and what was corrected by your patch? The summary isn't enough for explaining it, but you have more space here. thanks, Takashi
