On Fri, 21 Apr 2023 17:08:50 +0200, Oswald Buddenhagen wrote: > > On Fri, Apr 21, 2023 at 05:05:28PM +0200, Takashi Iwai wrote: > > On Fri, 21 Apr 2023 16:10:06 +0200, > > Oswald Buddenhagen wrote: > >> > >> If these are hit, we've already trashed kernel space. There is no > >> recovery from that. > >> > >> Signed-off-by: Oswald Buddenhagen <oswald.buddenhagen@xxxxxx> > > > > Sorry, it's a big NO-NO. BUG_ON() shouldn't be used here at all. > > > > BUG_ON() is used for the case you inevitably must stop everything > > immediately at this point. > > > yes, this is exactly what is intended, and i hoped that the commit > message makes it clear enough why. Not clear at all. Please explain in more details if we really *HAVE TO* use BUG_ON() there. thanks, Takashi
