On Thu, 20 Apr 2023 13:43:41 +0200, Oswald Buddenhagen wrote: > > - Update some outdated info > - Language fixes > - Whitespace/formatting fixes > - Prefer attached over stand-alone '::' > > Signed-off-by: Oswald Buddenhagen <oswald.buddenhagen@xxxxxx> > > --- > > v2: > - dropped questionable hunk from period timer example code > - new hunk: improved wording wrt period sizes Looks better, but I don't like putting FIXME's in the end result: > Callbacks are not atomic > ~~~~~~~~~~~~~~~~~~~~~~~~ > > -All these three callbacks are basically not atomic. > +All these three callbacks are basically (FIXME: but ...?) not atomic. You can omit the word "basically" and replace "not atomic" with "non-atomic". > +``SNDRV_DMA_TYPE_DEV_SG`` in the PCM constructor like for other PCI > +pre-allocations. You need to pass ``&pci->dev``, where pci is > +the struct pci_dev pointer of the chip as well:: > > snd_pcm_set_managed_buffer_all(pcm, SNDRV_DMA_TYPE_DEV_SG, > &pci->dev, size, max); > > +// FIXME: dma_private again I don't understand what are you asking here. "dma_private" has been already described in the early section. thanks, Takashi
