On Thu, Apr 20, 2023 at 12:16:12PM +0200, Krzysztof Kozlowski wrote: > - gpio_direction_output(wcd938x->reset_gpio, 0); > - /* 20us sleep required after pulling the reset gpio to LOW */ > + gpiod_set_value_cansleep(wcd938x->reset_gpio, 1); > + /* 20us sleep required after asserting the reset gpio */ This is inverting the sense of the GPIO in the API from active low to active high which will mean we're introducing a new reliance on having the signal described as active low in DT. That's an ABI concern. I remain deeply unconvinced that remapping active low outputs like this in the GPIO API is helping.
Attachment:
signature.asc
Description: PGP signature
