On 13/04/2023 13:27, Srinivas Kandagatla wrote:
RM_INTERRUPT_STATUS_RMSK);
>>
>> /* Configure No pings */
>> ctrl->reg_read(ctrl, SWRM_MCP_CFG_ADDR, &val);
>> u32p_replace_bits(&val, SWRM_DEF_CMD_NO_PINGS, SWRM_MCP_CFG_MAX_NUM_OF_CMD_NO_PINGS_BMSK);
>> ctrl->reg_write(ctrl, SWRM_MCP_CFG_ADDR, val);
>>
>> - if (ctrl->version >= SWRM_VERSION_1_7_0) {
>> + if (ctrl->version == SWRM_VERSION_1_7_0) {
>> ctrl->reg_write(ctrl, SWRM_LINK_MANAGER_EE, SWRM_EE_CPU);
>> ctrl->reg_write(ctrl, SWRM_MCP_BUS_CTRL,
>> SWRM_MCP_BUS_CLK_START << SWRM_EE_CPU);
>> + } else if (ctrl->version >= SWRM_VERSION_2_0_0) {
>
> we can move this to a proper switch case rather than if else's
OK
Best regards,
Krzysztof
