Re: [PATCH 1/2] ASoC: dt-bindings: nau8825: Add delay control for input path

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 14/04/2023 15:58, Krzysztof Kozlowski wrote:
> On 14/04/2023 15:46, Mark Brown wrote:
>> On Fri, Apr 14, 2023 at 02:34:19PM +0200, Krzysztof Kozlowski wrote:
>>> On 14/04/2023 12:39, David Lin wrote:
>>
>>>> +  - nuvoton,adc-delay-ms: Delay (in ms) to make input path stable and avoid pop noise. The
>>>> +      default value is 125 and range between 125 to 500 ms.
>>
>>> Convert the binding to DT Schema first.
>>
>> That seems disproportionate for such a trivial change.
> 
> What is the difference between:
> 1. Adding 2 or 3 new properties to TXT file without converting the file
> to DT Schema,
> 
> 2. Adding 1 property in 2022 Sep. Then adding one more property now.
> Then adding another property in 3 months.
> 
> I don't see.
> 
> Every time the excuse is the same - it is just one property, so let's
> add it. Since this is second property, after we started enforcing DT
> schema, I don't think my request is disproportionate.
> 

BTW, the change from September was also sent to mailing lists ignoring
Devicetree entirely. This does not help here, because now it looks like
a pattern.

Best regards,
Krzysztof




[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux