On Wed, Apr 12, 2023, at 10:47 AM, Limonciello, Mario wrote:
> [Public]
>
> Loop Mark Pearson from Lenovo for awareness.
>
>> -----Original Message-----
>> From: Baishan Jiang <bjiang400@xxxxxxxxxxx>
>> Sent: Wednesday, April 12, 2023 03:41
>> To: Mark Brown <broonie@xxxxxxxxxx>; Takashi Iwai <tiwai@xxxxxxxx>;
>> Limonciello, Mario <Mario.Limonciello@xxxxxxx>; alsa-devel@alsa-
>> project.org
>> Cc: Baishan Jiang <bjiang400@xxxxxxxxxxx>
>> Subject: [PATCH v2] ASoC: amd: yc: Add ThinkBook 14 G5+ ARP to quirks list
>> for acp6x
>>
>> ThinkBook 14 G5+ ARP uses Ryzen 7735H processor, and has the same
>> microphone problem as ThinkBook 14 G4+ ARA.
>>
>> Adding 21HY to acp6x quirks table enables microphone for ThinkBook
>> 14 G5+ ARP.
>>
>> Signed-off-by: Baishan Jiang <bjiang400@xxxxxxxxxxx>
>
> It would be generally preferred for systems to start including the _DSD in the
> BIOS so we can stop growing the quirk list, but if they don't then patches like
> this make sense.
Ack. I've forwarded to the FW team. Internal ticket is LO-2404.
Realistically though - I'd recommend still carrying on with the patch. This platform isn't in the Linux program and it could take me a while to see if I can get them to accept making changes I'm afraid.
Mark
>
> Reviewed-by: Mario Limonciello <mario.limonciello@xxxxxxx>
>
>> ---
>> V1 -> V2: Fixed signed-off-by format
>> ---
>> sound/soc/amd/yc/acp6x-mach.c | 7 +++++++
>> 1 file changed, 7 insertions(+)
>>
>> diff --git a/sound/soc/amd/yc/acp6x-mach.c b/sound/soc/amd/yc/acp6x-
>> mach.c
>> index 0acdf0156f07..62d8a8e060d2 100644
>> --- a/sound/soc/amd/yc/acp6x-mach.c
>> +++ b/sound/soc/amd/yc/acp6x-mach.c
>> @@ -178,6 +178,13 @@ static const struct dmi_system_id
>> yc_acp_quirk_table[] = {
>> DMI_MATCH(DMI_PRODUCT_NAME, "21EN"),
>> }
>> },
>> + {
>> + .driver_data = &acp6x_card,
>> + .matches = {
>> + DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
>> + DMI_MATCH(DMI_PRODUCT_NAME, "21HY"),
>> + }
>> + },
>> {
>> .driver_data = &acp6x_card,
>> .matches = {
>> --
>> 2.40.0
