--- Begin Message ---
- To: Baishan Jiang <bjiang400@xxxxxxxxxxx>, Mark Brown <broonie@xxxxxxxxxx>, Takashi Iwai <tiwai@xxxxxxxx>, "alsa-devel@xxxxxxxxxxxxxxxx" <alsa-devel@xxxxxxxxxxxxxxxx>, Mark Pearson <mpearson-lenovo@xxxxxxxxx>
- Subject: RE: [PATCH v2] ASoC: amd: yc: Add ThinkBook 14 G5+ ARP to quirks list for acp6x
- From: "Limonciello, Mario" <Mario.Limonciello@xxxxxxx>
- Date: Wed, 12 Apr 2023 14:47:01 +0000
- In-reply-to: <OS3P286MB1711DD6556284B69C79C0C4FE19B9@OS3P286MB1711.JPNP286.PROD.OUTLOOK.COM>
- Msip_label_d4243a53-6221-4f75-8154-e4b33a5707a1_actionid: ba074258-e387-4594-8a0c-db5d30e3f898
- Msip_label_d4243a53-6221-4f75-8154-e4b33a5707a1_contentbits: 0
- Msip_label_d4243a53-6221-4f75-8154-e4b33a5707a1_enabled: true
- Msip_label_d4243a53-6221-4f75-8154-e4b33a5707a1_method: Privileged
- Msip_label_d4243a53-6221-4f75-8154-e4b33a5707a1_name: Public-AIP 2.0
- Msip_label_d4243a53-6221-4f75-8154-e4b33a5707a1_setdate: 2023-04-12T14:46:59Z
- Msip_label_d4243a53-6221-4f75-8154-e4b33a5707a1_siteid: 3dd8961f-e488-4e60-8e11-a82d994e183d
- Msip_labels: MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_Enabled=true; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_SetDate=2023-04-12T14:46:59Z; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_Method=Privileged; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_Name=Public-AIP 2.0; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_ActionId=61fb2d1e-8cb9-4b9a-a821-334c7aceca1b; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_ContentBits=1
- References: <OS3P286MB1711DD6556284B69C79C0C4FE19B9@OS3P286MB1711.JPNP286.PROD.OUTLOOK.COM>
[Public]
Loop Mark Pearson from Lenovo for awareness.
> -----Original Message-----
> From: Baishan Jiang <bjiang400@xxxxxxxxxxx>
> Sent: Wednesday, April 12, 2023 03:41
> To: Mark Brown <broonie@xxxxxxxxxx>; Takashi Iwai <tiwai@xxxxxxxx>;
> Limonciello, Mario <Mario.Limonciello@xxxxxxx>; alsa-devel@alsa-
> project.org
> Cc: Baishan Jiang <bjiang400@xxxxxxxxxxx>
> Subject: [PATCH v2] ASoC: amd: yc: Add ThinkBook 14 G5+ ARP to quirks list
> for acp6x
>
> ThinkBook 14 G5+ ARP uses Ryzen 7735H processor, and has the same
> microphone problem as ThinkBook 14 G4+ ARA.
>
> Adding 21HY to acp6x quirks table enables microphone for ThinkBook
> 14 G5+ ARP.
>
> Signed-off-by: Baishan Jiang <bjiang400@xxxxxxxxxxx>
It would be generally preferred for systems to start including the _DSD in the
BIOS so we can stop growing the quirk list, but if they don't then patches like
this make sense.
Reviewed-by: Mario Limonciello <mario.limonciello@xxxxxxx>
> ---
> V1 -> V2: Fixed signed-off-by format
> ---
> sound/soc/amd/yc/acp6x-mach.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/sound/soc/amd/yc/acp6x-mach.c b/sound/soc/amd/yc/acp6x-
> mach.c
> index 0acdf0156f07..62d8a8e060d2 100644
> --- a/sound/soc/amd/yc/acp6x-mach.c
> +++ b/sound/soc/amd/yc/acp6x-mach.c
> @@ -178,6 +178,13 @@ static const struct dmi_system_id
> yc_acp_quirk_table[] = {
> DMI_MATCH(DMI_PRODUCT_NAME, "21EN"),
> }
> },
> + {
> + .driver_data = &acp6x_card,
> + .matches = {
> + DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
> + DMI_MATCH(DMI_PRODUCT_NAME, "21HY"),
> + }
> + },
> {
> .driver_data = &acp6x_card,
> .matches = {
> --
> 2.40.0
--- End Message ---