--- Begin Message ---
- To: "broonie@xxxxxxxxxx" <broonie@xxxxxxxxxx>, "groeck@xxxxxxxxxxxx" <groeck@xxxxxxxxxxxx>, "tiwai@xxxxxxxx" <tiwai@xxxxxxxx>, "lgirdwood@xxxxxxxxx" <lgirdwood@xxxxxxxxx>, "matthias.bgg@xxxxxxxxx" <matthias.bgg@xxxxxxxxx>, "shraash@xxxxxxxxxx" <shraash@xxxxxxxxxx>, "perex@xxxxxxxx" <perex@xxxxxxxx>, "angelogioacchino.delregno@xxxxxxxxxxxxx" <angelogioacchino.delregno@xxxxxxxxxxxxx>
- Subject: Re: [PATCH] ASoC: mediatek: common: Fix refcount leak in parse_dai_link_info
- From: Trevor Wu (吳文良) <Trevor.Wu@xxxxxxxxxxxx>
- Date: Tue, 11 Apr 2023 03:32:13 +0000
- Cc: "linux-arm-kernel@xxxxxxxxxxxxxxxxxxx" <linux-arm-kernel@xxxxxxxxxxxxxxxxxxx>, "linux-kernel@xxxxxxxxxxxxxxx" <linux-kernel@xxxxxxxxxxxxxxx>, "linux-mediatek@xxxxxxxxxxxxxxxxxxx" <linux-mediatek@xxxxxxxxxxxxxxxxxxx>, "lkp@xxxxxxxxx" <lkp@xxxxxxxxx>, "alsa-devel@xxxxxxxxxxxxxxxx" <alsa-devel@xxxxxxxxxxxxxxxx>, "julia.lawall@xxxxxxxx" <julia.lawall@xxxxxxxx>
- In-reply-to: <20230411003431.4048700-1-shraash@google.com>
- References: <20230411003431.4048700-1-shraash@google.com>
On Tue, 2023-04-11 at 06:04 +0530, Aashish Sharma wrote: > External email : Please do not click links or open attachments until > you have verified the sender or the content. > > > Add missing of_node_put()s before the returns to balance > of_node_get()s and of_node_put()s, which may get unbalanced > in case the for loop 'for_each_available_child_of_node' returns > early. > > Fixes: 4302187d955f ("ASoC: mediatek: common: add soundcard driver > common code") > Reported-by: kernel test robot <lkp@xxxxxxxxx> > Reported-by: Julia Lawall <julia.lawall@xxxxxxxx> > Link: https://lore.kernel.org/r/202304090504.2K8L6soj-lkp@xxxxxxxxx/ > Signed-off-by: Aashish Sharma <shraash@xxxxxxxxxx> Reviewed-by: Trevor Wu <trevor.wu@xxxxxxxxxxxx> > --- > sound/soc/mediatek/common/mtk-soundcard-driver.c | 12 +++++++++--- > 1 file changed, 9 insertions(+), 3 deletions(-) > > diff --git a/sound/soc/mediatek/common/mtk-soundcard-driver.c > b/sound/soc/mediatek/common/mtk-soundcard-driver.c > index 7c55c2cb1f21..738093451ccb 100644 > --- a/sound/soc/mediatek/common/mtk-soundcard-driver.c > +++ b/sound/soc/mediatek/common/mtk-soundcard-driver.c > @@ -47,20 +47,26 @@ int parse_dai_link_info(struct snd_soc_card > *card) > /* Loop over all the dai link sub nodes */ > for_each_available_child_of_node(dev->of_node, sub_node) { > if (of_property_read_string(sub_node, "link-name", > - &dai_link_name)) > + &dai_link_name)) { > + of_node_put(sub_node); > return -EINVAL; > + } > > for_each_card_prelinks(card, i, dai_link) { > if (!strcmp(dai_link_name, dai_link->name)) > break; > } > > - if (i >= card->num_links) > + if (i >= card->num_links) { > + of_node_put(sub_node); > return -EINVAL; > + } > > ret = set_card_codec_info(card, sub_node, dai_link); > - if (ret < 0) > + if (ret < 0) { > + of_node_put(sub_node); > return ret; > + } > } > > return 0; > -- > 2.40.0.577.gac1e443424-goog >
--- End Message ---
