RE: [PATCH] Add Dell G15 5525 Ryzen Edition to quirks list for acp6x so that internal DMIC works.

"Limonciello, Mario via Alsa-devel" <alsa-devel@xxxxxxxxxxxxxxxx> · Mon, 10 Apr 2023 15:52:47 +0000

--- Begin Message ---

To: Cem Kaya <cemkaya.boun@xxxxxxxxx>, "perex@xxxxxxxx" <perex@xxxxxxxx>,	"tiwai@xxxxxxxx" <tiwai@xxxxxxxx>
Subject: RE: [PATCH] Add Dell G15 5525 Ryzen Edition to quirks list for acp6x so that internal DMIC works.
From: "Limonciello, Mario" <Mario.Limonciello@xxxxxxx>
Date: Mon, 10 Apr 2023 15:52:47 +0000
Cc: "alsa-devel@xxxxxxxxxxxxxxxx" <alsa-devel@xxxxxxxxxxxxxxxx>, "linux-kernel@xxxxxxxxxxxxxxx" <linux-kernel@xxxxxxxxxxxxxxx>
In-reply-to: <20230410154928.171975-1-cemkaya.boun@gmail.com>
Msip_label_d4243a53-6221-4f75-8154-e4b33a5707a1_actionid:  4a847205-8278-4a17-80ef-dfb2a5556f2d
Msip_label_d4243a53-6221-4f75-8154-e4b33a5707a1_contentbits: 0
Msip_label_d4243a53-6221-4f75-8154-e4b33a5707a1_enabled: true
Msip_label_d4243a53-6221-4f75-8154-e4b33a5707a1_method: Privileged
Msip_label_d4243a53-6221-4f75-8154-e4b33a5707a1_name: Public-AIP 2.0
Msip_label_d4243a53-6221-4f75-8154-e4b33a5707a1_setdate: 2023-04-10T15:52:46Z
Msip_label_d4243a53-6221-4f75-8154-e4b33a5707a1_siteid:  3dd8961f-e488-4e60-8e11-a82d994e183d
Msip_labels: MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_Enabled=true; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_SetDate=2023-04-10T15:52:46Z; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_Method=Privileged; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_Name=Public-AIP 2.0; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_ActionId=4d9f44cb-df38-4fff-9601-847ec1f67c97; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_ContentBits=1
References: <20230410154928.171975-1-cemkaya.boun@gmail.com>

[Public]

> diff --git a/sound/soc/amd/yc/acp6x-mach.c b/sound/soc/amd/yc/acp6x-
> mach.c
> index a428e17f0325..e044d811496e 100644
> --- a/sound/soc/amd/yc/acp6x-mach.c
> +++ b/sound/soc/amd/yc/acp6x-mach.c
> @@ -45,6 +45,13 @@ static struct snd_soc_card acp6x_card = {
>  };
> 
>  static const struct dmi_system_id yc_acp_quirk_table[] = {
> +	{
> +		.driver_data = &acp6x_card,
> +		.matches = {
> +			DMI_MATCH(DMI_BOARD_VENDOR, "Dell Inc."),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "Dell G15
> 5525"),
> +		}
> +	},
>  	{
>  		.driver_data = &acp6x_card,
>  		.matches = {
> --
> 2.40.0

Hi,

Thanks for sending this up, but you'll need to add a few things:

1) You need to add a commit message explaining the why
2) You're missing a SoB tag (IE Signed-off-by: Foo Bar <foo@xxxxxxx>)
3) As this came from a kernel Bugzilla originally, suggest you to add Link tag:

Link: https://foo.bar.com/url

4) When you resubmit, please change PATCH to "PATCH v2"

--- End Message ---