On 4/5/23 10:22 AM, Maxime Ripard wrote:
Hi David,
On Wed, Apr 05, 2023 at 10:03:24AM -0500, David Lechner wrote:
On 4/4/23 5:11 AM, Maxime Ripard wrote:
The TI DA8xx USB0 clk48 clocks implements a mux with a set_parent
hook, but doesn't provide a determine_rate implementation.
This is a bit odd, since set_parent() is there to, as its name implies,
change the parent of a clock. However, the most likely candidate to
trigger that parent change is a call to clk_set_rate(), with
determine_rate() figuring out which parent is the best suited for a
given rate.
As mentioned in my previous review, parent is selected by device
tree and should never be changed after init.
Great minds think alike then, because the driver implements exactly
that, either before or after that patch.
That patch makes the current behaviour explicit but doesn't change it in
any way.
So I guess that means that I can add your Acked-by on the three patches
you reviewed with the same message?
Maxime
Yes, preferably with a simplified commit message.
Acked-by: David Lechner <david@xxxxxxxxxxxxxx>
