Re: [PATCH] ASoC: sunxi: handle reset_control_deassert() error

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Yangtao Li <frank.li@xxxxxxxx> 于2023年3月31日周五 11:01写道:

> Add error check for reset_control_deassert().
>
> Signed-off-by: Yangtao Li <frank.li@xxxxxxxx>
> ---
>  sound/soc/sunxi/sun50i-dmic.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/sound/soc/sunxi/sun50i-dmic.c b/sound/soc/sunxi/sun50i-dmic.c
> index 069c993acb31..7f0e63130d95 100644
> --- a/sound/soc/sunxi/sun50i-dmic.c
> +++ b/sound/soc/sunxi/sun50i-dmic.c
> @@ -345,7 +345,11 @@ static int sun50i_dmic_probe(struct platform_device
> *pdev)
>         if (IS_ERR(host->rst))
>                 return dev_err_probe(&pdev->dev, PTR_ERR(host->rst),
>                                      "Failed to get reset.\n");
> -       reset_control_deassert(host->rst);
> +       ret = reset_control_deassert(host->rst);
> +       if (ret) {
> +               dev_err(&pdev->dev, "failed to deassert reset: %d\n", ret);
>
Please use "dev_err_probe(...)"

> +               return ret;
> +       }
>
        ret = devm_snd_soc_register_component(&pdev->dev,
> &sun50i_dmic_component,
>                                               &sun50i_dmic_dai, 1);
> --
> 2.35.1
>
>




[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux