On 2023/3/30 15:39, Krzysztof Kozlowski wrote: > On 29/03/2023 17:33, Walker Chen wrote: >> Add bindings to describe the TDM driver for the StarFive JH7110 SoC. >> >> Signed-off-by: Walker Chen <walker.chen@xxxxxxxxxxxxxxxx> >> --- >> .../bindings/sound/starfive,jh7110-tdm.yaml | 95 +++++++++++++++++++ >> 1 file changed, 95 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/sound/starfive,jh7110-tdm.yaml >> >> diff --git a/Documentation/devicetree/bindings/sound/starfive,jh7110-tdm.yaml b/Documentation/devicetree/bindings/sound/starfive,jh7110-tdm.yaml >> new file mode 100644 >> index 000000000000..d65b9ed781ef >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/sound/starfive,jh7110-tdm.yaml >> @@ -0,0 +1,95 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/sound/starfive,jh7110-tdm.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: StarFive JH7110 TDM Controller >> + >> +description: | >> + The TDM Controller is a Time Division Multiplexed audio interface >> + integrated in StarFive JH7110 SoC, allowing up to 8 channels of >> + audio over a serial interface. The TDM controller can operate both >> + in master and slave mode. >> + >> +maintainers: >> + - Walker Chen <walker.chen@xxxxxxxxxxxxxxxx> >> + > > Missing allOf: with $ref to dai-common. Indeed missing allOf, thank you for kind reminding. > >> +properties: >> + compatible: >> + enum: >> + - starfive,jh7110-tdm >> + >> + reg: >> + maxItems: 1 > > (...) > >> +required: >> + - compatible >> + - reg >> + - clocks >> + - clock-names >> + - resets >> + - dmas >> + - dma-names >> + - "#sound-dai-cells" >> + >> +additionalProperties: false >> + >> +examples: >> + - | >> + tdm: tdm@10090000 { > > Drop tdm label, not used. Ok, will drop it. Best regards, Walker
