'rv' is of type unsigned int, which can never be less than zero.
rv = pm_runtime_resume_and_get(cs35l56->dev);
if (rv < 0) { // can never be true.
...
}
As pm_runtime_resume_and_get returns integers, change the type of 'rv'
to int to fix this.
This is found by static analysis with smatch.
Fixes: e49611252900 ("ASoC: cs35l56: Add driver for Cirrus Logic CS35L56")
Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@xxxxxxxxxx>
---
Only compile tested.
---
sound/soc/codecs/cs35l56.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/sound/soc/codecs/cs35l56.c b/sound/soc/codecs/cs35l56.c
index 90fc79b5666d..b3772005668a 100644
--- a/sound/soc/codecs/cs35l56.c
+++ b/sound/soc/codecs/cs35l56.c
@@ -321,7 +321,8 @@ irqreturn_t cs35l56_irq(int irq, void *data)
struct cs35l56_private *cs35l56 = data;
unsigned int status1 = 0, status8 = 0, status20 = 0;
unsigned int mask1, mask8, mask20;
- unsigned int rv, val;
+ unsigned int val;
+ int rv;
irqreturn_t ret = IRQ_NONE;
if (!cs35l56->init_done)
--
2.38.1
