On 28/03/2023 10:47, Saalim Quadri wrote: > Convert the AK4458 audio DAC bindings to DT schema. > > Signed-off-by: Saalim Quadri <danascape@xxxxxxxxx> (...) > + dvdd-supply: > + description: Digital power supply > + > + reset-gpios: > + maxItems: 1 > + > + mute-gpios: > + maxItems: 1 > + description: > + GPIO used to mute all the outputs > + > + dsd-path: > + description: Select DSD input pins for ak4497 > + $ref: /schemas/types.yaml#/definitions/uint32 > + oneOf: > + - const: 0 > + description: select #16, #17, #19 pins > + - const: 1 > + description: select #3, #4, #5 pins > + > +allOf: > + - if: > + properties: > + compatible: > + contains: > + const: asahi-kasei,ak4458 > + > + then: > + properties: > + dsd-path: false When I commented on adding allOf, I did it in specific place - after required before additionalProperties. You decided to put it in different place, not the one I asked. Also not the place example-schema is suggesting. The placement of people comments in emails is important. We answer here always inline, thus comments apply in the place they are given. Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> Best regards, Krzysztof
