--- Begin Message ---
- To: Banajit Goswami <bgoswami@xxxxxxxxxxx>, Jaroslav Kysela <perex@xxxxxxxx>, Takashi Iwai <tiwai@xxxxxxxx>
- Subject: [PATCH v3 1/1] sound: soc: codecs: wcd-mbhc-v2: expose ALSA control for jack
- From: Dylan Van Assche <me@xxxxxxxxxxxxxxxxx>
- Date: Sat, 25 Mar 2023 15:21:42 +0100
- Cc: Srinivas Kandagatla <srinivas.kandagatla@xxxxxxxxxx>, Liam Girdwood <lgirdwood@xxxxxxxxx>, Mark Brown <broonie@xxxxxxxxxx>, alsa-devel@xxxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, ~postmarketos/upstreaming@xxxxxxxxxxx, phone-devel@xxxxxxxxxxxxxxx, Dylan Van Assche <me@xxxxxxxxxxxxxxxxx>, Joel Selvaraj <joelselvaraj.oss@xxxxxxxxx>, Caleb Connolly <caleb@xxxxxxxxxxxxx>
- In-reply-to: <20230325142142.24337-1-me@dylanvanassche.be>
- References: <20230325142142.24337-1-me@dylanvanassche.be>
Jack detection is currently fully functional via the input interface together with multimedia buttons, but is not exposed as an ALSA control. Therefore, ALSA clients such as PulseAudio do not pick up the jack detection events as they only support one of the possible interface (ALSA control or input interface, but not both). Expose the jack events as an ALSA control and input interface to provide ALSA clients both interfaces. Signed-off-by: Dylan Van Assche <me@xxxxxxxxxxxxxxxxx> Tested-by: Joel Selvaraj <joelselvaraj.oss@xxxxxxxxx> Tested-by: Caleb Connolly <caleb@xxxxxxxxxxxxx> --- sound/soc/codecs/wcd-mbhc-v2.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/sound/soc/codecs/wcd-mbhc-v2.c b/sound/soc/codecs/wcd-mbhc-v2.c index 1911750f7445..1b75f49b2858 100644 --- a/sound/soc/codecs/wcd-mbhc-v2.c +++ b/sound/soc/codecs/wcd-mbhc-v2.c @@ -725,6 +725,10 @@ static int wcd_mbhc_initialise(struct wcd_mbhc *mbhc) mutex_lock(&mbhc->lock); + ret = snd_jack_add_new_kctl(mbhc->jack->jack, "Headset Jack", WCD_MBHC_JACK_MASK); + if (ret) + dev_warn(component->dev, "failed creating Headset Jack kctl with err: %d\n", ret); + /* enable HS detection */ if (mbhc->mbhc_cb->hph_pull_up_control_v2) mbhc->mbhc_cb->hph_pull_up_control_v2(component, -- 2.39.2
--- End Message ---
