Hi Richard, I love your patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v6.3-rc3 next-20230324] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Richard-Fitzgerald/firmware-cs_dsp-Add-a-debugfs-entry-containing-control-details/20230325-001218 patch link: https://lore.kernel.org/r/20230324161010.938599-1-rf%40opensource.cirrus.com patch subject: [PATCH] firmware: cs_dsp: Add a debugfs entry containing control details config: mips-randconfig-r005-20230322 (https://download.01.org/0day-ci/archive/20230325/202303251059.g8YEWRGa-lkp@xxxxxxxxx/config) compiler: mips-linux-gcc (GCC) 12.1.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/62afac6e0c35c0d7e44e0bd1e4b2af8380413164 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Richard-Fitzgerald/firmware-cs_dsp-Add-a-debugfs-entry-containing-control-details/20230325-001218 git checkout 62afac6e0c35c0d7e44e0bd1e4b2af8380413164 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=mips olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=mips SHELL=/bin/bash drivers/firmware/cirrus/ If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Link: https://lore.kernel.org/oe-kbuild-all/202303251059.g8YEWRGa-lkp@xxxxxxxxx/ All warnings (new ones prefixed by >>): drivers/firmware/cirrus/cs_dsp.c: In function 'cs_dsp_debugfs_read_controls_show': >> drivers/firmware/cirrus/cs_dsp.c:471:44: warning: format '%lx' expects argument of type 'long unsigned int', but argument 5 has type 'size_t' {aka 'unsigned int'} [-Wformat=] 471 | seq_printf(s, "%22.*s: %#8lx %s:%08x %#8x %s %#8x %#4x %c%c%c%c %s %s\n", | ~~~~^ | | | long unsigned int | %#8x 472 | ctl->subname_len, ctl->subname, ctl->len, | ~~~~~~~~ | | | size_t {aka unsigned int} vim +471 drivers/firmware/cirrus/cs_dsp.c 459 460 static int cs_dsp_coeff_base_reg(struct cs_dsp_coeff_ctl *ctl, unsigned int *reg, 461 unsigned int off); 462 463 static int cs_dsp_debugfs_read_controls_show(struct seq_file *s, void *ignored) 464 { 465 struct cs_dsp *dsp = s->private; 466 struct cs_dsp_coeff_ctl *ctl; 467 unsigned int reg; 468 469 list_for_each_entry(ctl, &dsp->ctl_list, list) { 470 cs_dsp_coeff_base_reg(ctl, ®, 0); > 471 seq_printf(s, "%22.*s: %#8lx %s:%08x %#8x %s %#8x %#4x %c%c%c%c %s %s\n", 472 ctl->subname_len, ctl->subname, ctl->len, 473 cs_dsp_mem_region_name(ctl->alg_region.type), 474 ctl->offset, reg, ctl->fw_name, ctl->alg_region.alg, ctl->type, 475 ctl->flags & WMFW_CTL_FLAG_VOLATILE ? 'V' : '-', 476 ctl->flags & WMFW_CTL_FLAG_SYS ? 'S' : '-', 477 ctl->flags & WMFW_CTL_FLAG_READABLE ? 'R' : '-', 478 ctl->flags & WMFW_CTL_FLAG_WRITEABLE ? 'W' : '-', 479 ctl->enabled ? "enabled" : "disabled", 480 ctl->set ? "dirty" : "clean"); 481 } 482 483 return 0; 484 } 485 DEFINE_SHOW_ATTRIBUTE(cs_dsp_debugfs_read_controls); 486 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests
