On 23/03/2023 14:05, Saalim Quadri wrote: > Convert the ALC5632 audio codec bindings to DT schema. > > Signed-off-by: Saalim Quadri <danascape@xxxxxxxxx> Thank you for your patch. There is something to discuss/improve. > @@ -0,0 +1,63 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/sound/realtek,alc5632.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: ALC5632 audio CODEC > + > +description: | > + Pins on the device (for linking into audio routes): > + * SPK_OUTP > + * SPK_OUTN > + * HP_OUT_L > + * HP_OUT_R > + * AUX_OUT_P > + * AUX_OUT_N > + * LINE_IN_L > + * LINE_IN_R > + * PHONE_P > + * PHONE_N > + * MIC1_P > + * MIC1_N > + * MIC2_P > + * MIC2_N > + * MICBIAS1 > + * DMICDAT > + > +maintainers: > + - Liam Girdwood <lgirdwood@xxxxxxxxx> This should not be subsystem maintainer but someone related to the device. It's maintainer or interested contributor. Unless that's the case here? > + > +properties: > + compatible: > + const: realtek,alc5632 > + > + reg: > + maxItems: 1 > + > + '#gpio-cells': > + const: 2 > + > + gpio-controller: true > + > +required: > + - compatible > + - reg > + - '#gpio-cells' > + - gpio-controller > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/gpio/gpio.h> > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + alc5632: alc5632@1a { Node name: codec and drop alc5632 label > + compatible = "realtek,alc5632"; > + reg = <0x1a>; > + gpio-controller; > + #gpio-cells = <2>; > + }; > + }; Best regards, Krzysztof
