--- Begin Message ---
- To: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
- Subject: Re: [PATCH v3 2/6] mfd: Add support for the Lantiq PEF2256 framer
- From: Herve Codina <herve.codina@xxxxxxxxxxx>
- Date: Thu, 23 Mar 2023 09:31:54 +0100
- Cc: Lee Jones <lee@xxxxxxxxxx>, Rob Herring <robh+dt@xxxxxxxxxx>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@xxxxxxxxxx>, Liam Girdwood <lgirdwood@xxxxxxxxx>, Mark Brown <broonie@xxxxxxxxxx>, Takashi Iwai <tiwai@xxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, devicetree@xxxxxxxxxxxxxxx, alsa-devel@xxxxxxxxxxxxxxxx, Christophe Leroy <christophe.leroy@xxxxxxxxxx>, Thomas Petazzoni <thomas.petazzoni@xxxxxxxxxxx>
- In-reply-to: <551fe9b4-4c99-74b8-af44-9f431c488af8@linaro.org>
- Organization: Bootlin
- References: <20230322134654.219957-1-herve.codina@bootlin.com> <20230322134654.219957-3-herve.codina@bootlin.com> <551fe9b4-4c99-74b8-af44-9f431c488af8@linaro.org>
On Thu, 23 Mar 2023 08:30:39 +0100
Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> wrote:
> On 22/03/2023 14:46, Herve Codina wrote:
> > The Lantiq PEF2256 is a framer and line interface component designed to
> > fulfill all required interfacing between an analog E1/T1/J1 line and the
> > digital PCM system highway/H.100 bus.
> >
> > Signed-off-by: Herve Codina <herve.codina@xxxxxxxxxxx>
>
>
> > +static const struct of_device_id pef2256_id_table[] = {
> > + { .compatible = "lantiq,pef2256" },
> > + {} /* sentinel */
> > +};
> > +MODULE_DEVICE_TABLE(of, pef2256_id_table);
> > +
> > +static struct platform_driver pef2256_driver = {
> > + .driver = {
> > + .name = "lantiq-pef2256",
> > + .of_match_table = of_match_ptr(pef2256_id_table),
>
> Drop of_match_ptr. This will case warnings with W=1 and !OF.
>
> Best regards,
> Krzysztof
>
Acked. Will be dropped in v4.
Thanks.
Hervé
--
Hervé Codina, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
--- End Message ---