On 21/03/2023 19:08, Saalim Quadri wrote:
> Convert the AK5558 ADC audio codec bindings to DT schema.
>
> Signed-off-by: Saalim Quadri <danascape@xxxxxxxxx>
> ---
> .../devicetree/bindings/sound/ak5558.txt | 24 ---------
> .../devicetree/bindings/sound/ak5558.yaml | 49 +++++++++++++++++++
> 2 files changed, 49 insertions(+), 24 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/sound/ak5558.txt
> create mode 100644 Documentation/devicetree/bindings/sound/ak5558.yaml
>
> diff --git a/Documentation/devicetree/bindings/sound/ak5558.txt b/Documentation/devicetree/bindings/sound/ak5558.txt
> deleted file mode 100644
> index e28708db6686..000000000000
> --- a/Documentation/devicetree/bindings/sound/ak5558.txt
> +++ /dev/null
> @@ -1,24 +0,0 @@
> -AK5558 8 channel differential 32-bit delta-sigma ADC
> -
> -This device supports I2C mode only.
> -
> -Required properties:
> -
> -- compatible : "asahi-kasei,ak5558" or "asahi-kasei,ak5552".
> -- reg : The I2C address of the device.
> -
> -Optional properties:
> -
> -- reset-gpios: A GPIO specifier for the power down & reset pin.
> -- AVDD-supply: Analog power supply
> -- DVDD-supply: Digital power supply
> -
> -Example:
> -
> -&i2c {
> - ak5558: adc@10 {
> - compatible = "asahi-kasei,ak5558";
> - reg = <0x10>;
> - reset-gpios = <&gpio1 10 GPIO_ACTIVE_LOW>;
> - };
> -};
> diff --git a/Documentation/devicetree/bindings/sound/ak5558.yaml b/Documentation/devicetree/bindings/sound/ak5558.yaml
> new file mode 100644
> index 000000000000..90fd734daeec
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/ak5558.yaml
Missing vendor prefix, so
asahi-kasei,ak5558.yaml
> @@ -0,0 +1,49 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/sound/ak5558.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: AK5558 ADC Device Tree Bindings
drop "Device Tree Bindings"
You dropped few pieces of device description. Why? Also ADC is very
confusing.
> +
> +maintainers:
> + - Junichi Wakasugi <wakasugi.jb@xxxxxxxxxxxxxxxxxxxx>
> + - Mihai Serban <mihai.serban@xxxxxxx>
> +
> +properties:
> + compatible:
> + enum:
> + - asahi-kasei,ak5558
> + - asahi-kasei,ak5552
Keep them ordered by name.
> +
> + reg:
> + maxItems: 1
> + description: I2C address of the device.
Drop description, obvious.
> +
> + avdd-supply:
> + description: A 1.8V supply that powers up the AVDD pin.
> +
> + dvdd-supply:
> + description: A 1.2V supply that powers up the DVDD pin.
> +
> + reset-gpios:
> + maxItems: 1
> +
Best regards,
Krzysztof
