Re: [PATCH 5/6] ASoC: simple-card-utils.c: remove unnecessary dai_link->platform

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Mark

Thank you for your test

> > dai_link->platform is no longer needed if CPU and Platform are
> > same Component. This patch removes unnecessary dai_link->platform.
> > 
> > Simple-Card (Normal) is supporting platform, but
> > Simple-Cadd (DPCM), Audio-Graph-Card/Card2 (Normal/DPCM) are not
> > for now.
> 
> A bisect tells me that this patch rather than the TI one is responsible
> for the issues I'm seeing on BeagleBone Black.

I see. I don't have BeagleBone thus this is my guess.
I think BeagleBone is using soc-generic-dmaengine-pcm.c.
This means, CPU and Platform are different Component,
but are using same dev (= component->dev).

In this case, this patch assumes BeagleBone need to have "plat = <&xxx>"
on DT (but it doesn't).
And Simple Card have been covered it automatically (It assumes Platform == CPU
if no Platform was selected).

Hmm... I recalled similar things happen before.
OK, please drop this patch. We want to keep existing DT as-is.

But instead, I want to post other patch which add comment to Simple-Card that
indicates Simple-Card is caring soc-generic-dmaengine-pcm automatically.
Otherwise I will forget it again, and will repost same/similar patch again :)

Thank you for your help !!

Best regards
---
Kuninori Morimoto



[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux