On Tue, Mar 21, 2023 at 04:56:51PM +0200, Peter Ujfalusi wrote: > The patch adding the bytes control support moved the error check outside > of the list_for_each_entry() which was not correct as at the end of the > list_for_each_entry() the scontrol will no longer point where the error > happened, but it to the list head. > > Restore the original logic and return on the first error with the error > code. > > Fixes: a062c8899fed ("ASoC: SOF: ipc4-control: Add support for bytes control get and put") > Reported-by: Dan Carpenter <error27@xxxxxxxxx> > Link: https://lore.kernel.org/alsa-devel/6be945d2-40cb-46fb-67ba-ed3a19cddfa4@xxxxxxxxxxxxxxx/T/#t > Signed-off-by: Peter Ujfalusi <peter.ujfalusi@xxxxxxxxxxxxxxx> > --- Awesome sauce! Thanks! regards, dan carpenter