--- Begin Message ---
- To: Charles Keepax <ckeepax@xxxxxxxxxxxxxxxxxxxxx>
- Subject: Re: [PATCH v2 4/5] ASoC: cs35l45: DSP Support
- From: Vlad Karpovich <vkarpovi@xxxxxxxxxxxxxxxxxxxxx>
- Date: Mon, 13 Mar 2023 14:18:38 -0500
- Cc: James Schulman <james.schulman@xxxxxxxxxx>, David Rhodes <david.rhodes@xxxxxxxxxx>, Richard Fitzgerald <rf@xxxxxxxxxxxxxxxxxxxxx>, Liam Girdwood <lgirdwood@xxxxxxxxx>, Mark Brown <broonie@xxxxxxxxxx>, Takashi Iwai <tiwai@xxxxxxxx>, alsa-devel@xxxxxxxxxxxxxxxx, patches@xxxxxxxxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, Ricardo Rivera-Matos <rriveram@xxxxxxxxxxxxxxxxxxxxx>
- In-reply-to: <20230306092652.GP68926@ediswmail.ad.cirrus.com>
- References: <20230303192151.2437221-1-vkarpovi@opensource.cirrus.com> <20230303192151.2437221-4-vkarpovi@opensource.cirrus.com> <20230306092652.GP68926@ediswmail.ad.cirrus.com>
- User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1
On 3/6/23 03:26, Charles Keepax wrote:
On Fri, Mar 03, 2023 at 01:21:50PM -0600, Vlad Karpovich wrote:
From: "Vlad.Karpovich" <vkarpovi@xxxxxxxxxxxxxxxxxxxxx>
The CS35L45 digital core incorporates one programmable DSP block,
capable of running a wide range of audio enhancement and speaker
and battery protection functions.
Signed-off-by: Vlad Karpovich <vkarpovi@xxxxxxxxxxxxxxxxxxxxx>
---
+#define CS35L45_DAC_MUX_ROUTE(name) \
+ { name" Source", "ASP_RX1", "ASP_RX1" }, \
+ { name" Source", "ASP_RX2", "ASP_RX2" }, \
+ { name" Source", "DSP_TX1", "DSP1" }, \
+ { name" Source", "DSP_TX2", "DSP1" }
+
+
Minor nit, double blank line here.
Thanks. I will fix it
But otherwise looks pretty good to me:
Acked-by: Charles Keepax <ckeepax@xxxxxxxxxxxxxxxxxxxxx>
Thanks,
Charles
--- End Message ---
