--- Begin Message ---
- To: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
- Subject: Re: [PATCH 114/173] ASoC: meson: aiu: Convert to platform remove callback returning void
- From: Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx>
- Date: Sat, 18 Mar 2023 20:49:26 +0100
- Cc: Jerome Brunet <jbrunet@xxxxxxxxxxxx>, Liam Girdwood <lgirdwood@xxxxxxxxx>, Mark Brown <broonie@xxxxxxxxxx>, Takashi Iwai <tiwai@xxxxxxxx>, Neil Armstrong <neil.armstrong@xxxxxxxxxx>, Kevin Hilman <khilman@xxxxxxxxxxxx>, alsa-devel@xxxxxxxxxxxxxxxx, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, linux-amlogic@xxxxxxxxxxxxxxxxxxx, kernel@xxxxxxxxxxxxxx
- In-reply-to: <20230315150745.67084-115-u.kleine-koenig@pengutronix.de>
- References: <20230315150745.67084-1-u.kleine-koenig@pengutronix.de> <20230315150745.67084-115-u.kleine-koenig@pengutronix.de>
On Wed, Mar 15, 2023 at 4:08 PM Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx> wrote: > > The .remove() callback for a platform driver returns an int which makes > many driver authors wrongly assume it's possible to do error handling by > returning an error code. However the value returned is (mostly) ignored > and this typically results in resource leaks. To improve here there is a > quest to make the remove callback return void. In the first step of this > quest all drivers are converted to .remove_new() which already returns > void. > > Trivially convert this driver from always returning zero in the remove > callback to the void returning variant. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx> Acked-by: Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx>
--- End Message ---
