On 16/03/2023 13:27, Herve Codina wrote: > The Lantiq PEF2256, also known as Infineon PEF2256 or FALC256, is a > framer and line interface component designed to fulfill all required > interfacing between an analog E1/T1/J1 line and the digital PCM system > highway/H.100 bus. > > The codec support allows to use some of the PCM system highway > time-slots as audio channels to transport audio data over the E1/T1/J1 > lines. > Your other file should also have specific compatible, unless this codec is actually part of the framer. Did not look like this in the binding - not $ref. > Signed-off-by: Herve Codina <herve.codina@xxxxxxxxxxx> > --- > .../bindings/sound/lantiq,pef2256-codec.yaml | 57 +++++++++++++++++++ > 1 file changed, 57 insertions(+) > create mode 100644 Documentation/devicetree/bindings/sound/lantiq,pef2256-codec.yaml > > diff --git a/Documentation/devicetree/bindings/sound/lantiq,pef2256-codec.yaml b/Documentation/devicetree/bindings/sound/lantiq,pef2256-codec.yaml > new file mode 100644 > index 000000000000..acba3a0ccd1b > --- /dev/null > +++ b/Documentation/devicetree/bindings/sound/lantiq,pef2256-codec.yaml > @@ -0,0 +1,57 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/sound/lantiq,pef2256-codec.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Lantiq PEF2256 codec device Drop "device". Everything is "device". > + > +maintainers: > + - Herve Codina <herve.codina@xxxxxxxxxxx> > + > +description: | > + Codec support for PEF2256. > + > + The Lantiq PEF2256, also known as Infineon PEF2256 or FALC256, is a framer and > + line interface component designed to fulfill all required interfacing between > + an analog E1/T1/J1 line and the digital PCM system highway/H.100 bus. > + > + The codec support allows to use some of the PCM system highway time-slots as > + audio channels to transport audio data over the E1/T1/J1 lines. > + > + The time-slots used by the codec must be set and so, the properties > + 'dai-tdm-slot-num', 'dai-tdm-slot-width', 'dai-tdm-slot-tx-mask' and > + 'dai-tdm-slot-rx-mask' must be present in the ALSA sound card node for > + sub-nodes that involve the codec. The codec uses 8bit time-slots. > + 'dai-tdm-tdm-slot-with' must be set to 8. > + > +allOf: > + - $ref: /schemas/spi/spi-peripheral-props.yaml# > + - $ref: dai-common.yaml# > + > +properties: > + compatible: > + const: lantiq,pef2256-codec > + > + lantiq,pef2256: > + $ref: /schemas/types.yaml#/definitions/phandle > + description: > + phandle to the PEF2256 Why not its child? Why this is in parallel ? > + > + '#sound-dai-cells': > + const: 0 > + Best regards, Krzysztof
