--- Begin Message ---
- To: <u.kleine-koenig@xxxxxxxxxxxxxx>, <codrin.ciubotariu@xxxxxxxxxxxxx>, <lgirdwood@xxxxxxxxx>, <broonie@xxxxxxxxxx>, <perex@xxxxxxxx>, <tiwai@xxxxxxxx>, <Nicolas.Ferre@xxxxxxxxxxxxx>, <alexandre.belloni@xxxxxxxxxxx>
- Subject: Re: [PATCH 025/173] ASoC: atmel: atmel_wm8904: Convert to platform remove callback returning void
- From: <Claudiu.Beznea@xxxxxxxxxxxxx>
- Date: Thu, 16 Mar 2023 11:09:36 +0000
- Cc: alsa-devel@xxxxxxxxxxxxxxxx, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, kernel@xxxxxxxxxxxxxx
- In-reply-to: <20230315150745.67084-26-u.kleine-koenig@pengutronix.de>
- References: <20230315150745.67084-1-u.kleine-koenig@pengutronix.de> <20230315150745.67084-26-u.kleine-koenig@pengutronix.de>
- User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0
On 15.03.2023 17:05, Uwe Kleine-König wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > The .remove() callback for a platform driver returns an int which makes > many driver authors wrongly assume it's possible to do error handling by > returning an error code. However the value returned is (mostly) ignored > and this typically results in resource leaks. To improve here there is a > quest to make the remove callback return void. In the first step of this > quest all drivers are converted to .remove_new() which already returns > void. > > Trivially convert this driver from always returning zero in the remove > callback to the void returning variant. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx> Reviewed-by: Claudiu Beznea <claudiu.beznea@xxxxxxxxxxxxx> > --- > sound/soc/atmel/atmel_wm8904.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/sound/soc/atmel/atmel_wm8904.c b/sound/soc/atmel/atmel_wm8904.c > index 9c974c4e187d..00e98136bec2 100644 > --- a/sound/soc/atmel/atmel_wm8904.c > +++ b/sound/soc/atmel/atmel_wm8904.c > @@ -161,7 +161,7 @@ static int atmel_asoc_wm8904_probe(struct platform_device *pdev) > return ret; > } > > -static int atmel_asoc_wm8904_remove(struct platform_device *pdev) > +static void atmel_asoc_wm8904_remove(struct platform_device *pdev) > { > struct snd_soc_card *card = platform_get_drvdata(pdev); > struct snd_soc_dai_link *dailink = &atmel_asoc_wm8904_dailink; > @@ -171,8 +171,6 @@ static int atmel_asoc_wm8904_remove(struct platform_device *pdev) > > snd_soc_unregister_card(card); > atmel_ssc_put_audio(id); > - > - return 0; > } > > #ifdef CONFIG_OF > @@ -190,7 +188,7 @@ static struct platform_driver atmel_asoc_wm8904_driver = { > .pm = &snd_soc_pm_ops, > }, > .probe = atmel_asoc_wm8904_probe, > - .remove = atmel_asoc_wm8904_remove, > + .remove_new = atmel_asoc_wm8904_remove, > }; > > module_platform_driver(atmel_asoc_wm8904_driver); > -- > 2.39.2 >
--- End Message ---
