Re: [PATCH 000/173] ALSA/ASoC: Convert to platform remove callback returning void

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Mar 15, 2023 at 05:23:23PM +0000, Mark Brown wrote:
> On Wed, Mar 15, 2023 at 04:04:52PM +0100, Uwe Kleine-König wrote:
> > Hello,
> > 
> > this series adapts the platform drivers below sound/ to use the .remove_new()
> > callback. Compared to the traditional .remove() callback .remove_new() returns
> > no value. This is a good thing because the driver core doesn't (and cannot)
> > cope for errors during remove. The only effect of a non-zero return value in
> > .remove() is that the driver core emits a warning. The device is removed anyhow
> > and an early return from .remove() usually yields a resource leak.
> 
> ALSA and ASoC patches generally get applied to separate trees so it's
> probably better to send them separately unless there's dependencies.

OK, I should have considered that giving that the subject prefixes are
also different, sorry. I hope to remember that for the next quest.

I won't resend this series split in two for this development cycle but
address this for the next merge window, taking into account patches
that were applied despite your hint.

As things stand now that would be for ALSA:

	b4 am -l -t -P1,3-12,172-173 20230315150745.67084-1-u.kleine-koenig@xxxxxxxxxxxxxx

and for ASoC:

	b4 am -l -t -P2,13-119,121-171 20230315150745.67084-1-u.kleine-koenig@xxxxxxxxxxxxxx

Oh, but I see Takashi suggested to take them all via ASoC, in this case
just skip patch 120.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux