--- Begin Message ---
- To: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
- Subject: Re: [PATCH 046/173] ASoC: codecs: cs47l90: Convert to platform remove callback returning void
- From: Charles Keepax <ckeepax@xxxxxxxxxxxxxxxxxxxxx>
- Date: Thu, 16 Mar 2023 09:18:19 +0000
- Cc: Richard Fitzgerald <rf@xxxxxxxxxxxxxxxxxxxxx>, James Schulman <james.schulman@xxxxxxxxxx>, David Rhodes <david.rhodes@xxxxxxxxxx>, Lucas Tanure <tanureal@xxxxxxxxxxxxxxxxxxxxx>, Liam Girdwood <lgirdwood@xxxxxxxxx>, Mark Brown <broonie@xxxxxxxxxx>, Takashi Iwai <tiwai@xxxxxxxx>, alsa-devel@xxxxxxxxxxxxxxxx, patches@xxxxxxxxxxxxxxxxxxxxx, kernel@xxxxxxxxxxxxxx
- In-reply-to: <20230315150745.67084-47-u.kleine-koenig@pengutronix.de>
- References: <20230315150745.67084-1-u.kleine-koenig@pengutronix.de> <20230315150745.67084-47-u.kleine-koenig@pengutronix.de>
- User-agent: Mutt/1.5.21 (2010-09-15)
On Wed, Mar 15, 2023 at 04:05:38PM +0100, Uwe Kleine-König wrote: > The .remove() callback for a platform driver returns an int which makes > many driver authors wrongly assume it's possible to do error handling by > returning an error code. However the value returned is (mostly) ignored > and this typically results in resource leaks. To improve here there is a > quest to make the remove callback return void. In the first step of this > quest all drivers are converted to .remove_new() which already returns > void. > > Trivially convert this driver from always returning zero in the remove > callback to the void returning variant. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx> > --- Acked-by: Charles Keepax <ckeepax@xxxxxxxxxxxxxxxxxxxxx> Thanks, Charles
--- End Message ---
