--- Begin Message ---
- To: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>, Liam Girdwood <lgirdwood@xxxxxxxxx>, Mark Brown <broonie@xxxxxxxxxx>, Jaroslav Kysela <perex@xxxxxxxx>, Takashi Iwai <tiwai@xxxxxxxx>, Matthias Brugger <matthias.bgg@xxxxxxxxx>, Ricardo Ribalda <ribalda@xxxxxxxxxxxx>, Minghao Chi <chi.minghao@xxxxxxxxxx>
- Subject: Re: [PATCH 109/173] ASoC: mediatek: mt8173-afe-pcm: Convert to platform remove callback returning void
- From: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>
- Date: Thu, 16 Mar 2023 09:42:08 +0100
- Cc: alsa-devel@xxxxxxxxxxxxxxxx, kernel@xxxxxxxxxxxxxx, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, linux-mediatek@xxxxxxxxxxxxxxxxxxx
- In-reply-to: <20230315150745.67084-110-u.kleine-koenig@pengutronix.de>
- References: <20230315150745.67084-1-u.kleine-koenig@pengutronix.de> <20230315150745.67084-110-u.kleine-koenig@pengutronix.de>
- User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0
Il 15/03/23 16:06, Uwe Kleine-König ha scritto:
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.
Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>
--- End Message ---
