On Wed, Mar 15, 2023 at 05:00:49PM +0100, Nicolas Frattaroli wrote: > On Mittwoch, 15. März 2023 16:06:52 CET Uwe Kleine-König wrote: > > The .remove() callback for a platform driver returns an int which makes > > many driver authors wrongly assume it's possible to do error handling by > > returning an error code. However the value returned is (mostly) ignored > > and this typically results in resource leaks. To improve here there is a > > quest to make the remove callback return void. In the first step of this > > quest all drivers are converted to .remove_new() which already returns > > void. > > > > Trivially convert this driver from always returning zero in the remove > > callback to the void returning variant. > > > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx> > > Hello, > > this looks fine, but the commit prefix should either be > "ASoC: rockchip: i2s_tdm:" or "ASoC: rockchip: i2s-tdm" to align > with previous commits. We've already broken convention once before, > hence the two names, and I'd rather not have this convention broken > again. I fixed that in my tree. I assume Mark will skip this patch when applying and when I come around cleaning up the fall-out I will resend this one with the subject fixed. (I picked the variant with _ now as this seems to be the more recent one.) Thanks for the feedback Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ |
Attachment:
signature.asc
Description: PGP signature
