Dne sreda, 15. marec 2023 ob 16:07:15 CET je Uwe Kleine-König napisal(a): > The .remove() callback for a platform driver returns an int which makes > many driver authors wrongly assume it's possible to do error handling by > returning an error code. However the value returned is (mostly) ignored > and this typically results in resource leaks. To improve here there is a > quest to make the remove callback return void. In the first step of this > quest all drivers are converted to .remove_new() which already returns > void. > > Trivially convert this driver from always returning zero in the remove > callback to the void returning variant. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx> Acked-by: Jernej Skrabec <jernej.skrabec@xxxxxxxxx> Best regards, Jernej > --- > sound/soc/sunxi/sun50i-dmic.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/sound/soc/sunxi/sun50i-dmic.c b/sound/soc/sunxi/sun50i-dmic.c > index 069c993acb31..c10439b9e0a2 100644 > --- a/sound/soc/sunxi/sun50i-dmic.c > +++ b/sound/soc/sunxi/sun50i-dmic.c > @@ -373,13 +373,11 @@ static int sun50i_dmic_probe(struct platform_device > *pdev) return ret; > } > > -static int sun50i_dmic_remove(struct platform_device *pdev) > +static void sun50i_dmic_remove(struct platform_device *pdev) > { > pm_runtime_disable(&pdev->dev); > if (!pm_runtime_status_suspended(&pdev->dev)) > sun50i_dmic_runtime_suspend(&pdev->dev); > - > - return 0; > } > > static const struct dev_pm_ops sun50i_dmic_pm = { > @@ -394,7 +392,7 @@ static struct platform_driver sun50i_dmic_driver = { > .pm = &sun50i_dmic_pm, > }, > .probe = sun50i_dmic_probe, > - .remove = sun50i_dmic_remove, > + .remove_new = sun50i_dmic_remove, > }; > > module_platform_driver(sun50i_dmic_driver);