Dne sreda, 15. marec 2023 ob 16:07:12 CET je Uwe Kleine-König napisal(a): > The .remove() callback for a platform driver returns an int which makes > many driver authors wrongly assume it's possible to do error handling by > returning an error code. However the value returned is (mostly) ignored > and this typically results in resource leaks. To improve here there is a > quest to make the remove callback return void. In the first step of this > quest all drivers are converted to .remove_new() which already returns > void. > > Trivially convert this driver from always returning zero in the remove > callback to the void returning variant. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx> Acked-by: Jernej Skrabec <jernej.skrabec@xxxxxxxxx> Best regards, Jernej > --- > sound/soc/sunxi/sun4i-codec.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/sound/soc/sunxi/sun4i-codec.c b/sound/soc/sunxi/sun4i-codec.c > index 835dc3404367..55328850aef5 100644 > --- a/sound/soc/sunxi/sun4i-codec.c > +++ b/sound/soc/sunxi/sun4i-codec.c > @@ -1821,7 +1821,7 @@ static int sun4i_codec_probe(struct platform_device > *pdev) return ret; > } > > -static int sun4i_codec_remove(struct platform_device *pdev) > +static void sun4i_codec_remove(struct platform_device *pdev) > { > struct snd_soc_card *card = platform_get_drvdata(pdev); > struct sun4i_codec *scodec = snd_soc_card_get_drvdata(card); > @@ -1830,8 +1830,6 @@ static int sun4i_codec_remove(struct platform_device > *pdev) if (scodec->rst) > reset_control_assert(scodec->rst); > clk_disable_unprepare(scodec->clk_apb); > - > - return 0; > } > > static struct platform_driver sun4i_codec_driver = { > @@ -1840,7 +1838,7 @@ static struct platform_driver sun4i_codec_driver = { > .of_match_table = sun4i_codec_of_match, > }, > .probe = sun4i_codec_probe, > - .remove = sun4i_codec_remove, > + .remove_new = sun4i_codec_remove, > }; > module_platform_driver(sun4i_codec_driver);