On 11/03/2023 02:14, “Ryan wrote: > From: Ryan Lee <ryans.lee@xxxxxxxxxx> > > This patch adds dt-bindings information for Analog Devices MAX98363 > SoundWire Amplifier. > > Signed-off-by: Ryan Lee <ryans.lee@xxxxxxxxxx> > --- > Changes from v1: > Fixed a syntax error for the 'dt_binding_check' build. > Removed unnecessary properties. > Added description about SoundWire device ID of MAX98363 > > .../bindings/sound/adi,max98363.yaml | 42 +++++++++++++++++++ > 1 file changed, 42 insertions(+) > create mode 100644 Documentation/devicetree/bindings/sound/adi,max98363.yaml > > diff --git a/Documentation/devicetree/bindings/sound/adi,max98363.yaml b/Documentation/devicetree/bindings/sound/adi,max98363.yaml > new file mode 100644 > index 000000000000..0e71b6c84007 > --- /dev/null > +++ b/Documentation/devicetree/bindings/sound/adi,max98363.yaml > @@ -0,0 +1,42 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/sound/adi,max98363.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Analog Devices MAX98363 SoundWire Amplifier > + > +maintainers: > + - Ryan Lee <ryans.lee@xxxxxxxxxx> > + > +description: > + The MAX98363 is a SoundWire input Class D mono amplifier that > + supports MIPI SoundWire v1.2-compatible digital interface for > + audio and control data. > + SoundWire peripheral device ID of MAX98363 is 0x3X019F836300 > + where X is the peripheral device unique ID decoded from pin. > + It supports up to 10 peripheral devices(0x0 to 0x9). > + > +properties: > + compatible: > + enum: > + - adi,max98363 Aren't soundwire devices supposed to use device ID as compatible? Missing blank line > + reg: > + maxItems: 1 > + description: Peripheral-device unique ID decoded from pin. > + It's not a DAI? > +required: > + - compatible > + - reg Missing blank line > +additionalProperties: false > + > +examples: > + - | > + soundwire { > + #address-cells = <1>; > + #size-cells = <0>; > + amplifier@3 { > + compatible = "adi,max98363"; > + reg = <0x3>; That looks a bit different than regular SoundWire bus. I would argue that it's not SoundWire at all... > + }; > + }; Best regards, Krzysztof
