On 3/10/23 10:25, Vijendar Mukunda wrote: > AMD ACP(v6.x) IP block has two SoundWire manager devices. > Add support for > - Manager driver probe & remove sequence > - Helper functions to enable/disable interrupts, > Initialize sdw manager, enable sdw pads > - Manager driver sdw_master_ops & port_ops callbacks > > Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@xxxxxxx> Apart from debatable style issues in the way local variables are exposed (inconsistent use of multiple variables/line, random variations to reverse x-mas tree), this looks good enough to me for an initial contribution. Thanks for bearing with my feedback. Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@xxxxxxxxxxxxxxx>
