--- Begin Message ---
- To: <srinivas.kandagatla@xxxxxxxxxx>, <perex@xxxxxxxx>, <tiwai@xxxxxxxx>, <lgirdwood@xxxxxxxxx>, <broonie@xxxxxxxxxx>, <james.schulman@xxxxxxxxxx>, <david.rhodes@xxxxxxxxxx>, <tanureal@xxxxxxxxxxxxxxxxxxxxx>, <rf@xxxxxxxxxxxxxxxxxxxxx>, <oder_chiou@xxxxxxxxxxx>, <shengjiu.wang@xxxxxxxxx>, <Xiubo.Lee@xxxxxxxxx>, <festevam@xxxxxxxxx>, <nicoleotsuka@xxxxxxxxx>, <shawnguo@xxxxxxxxxx>, <s.hauer@xxxxxxxxxxxxxx>, <kernel@xxxxxxxxxxxxxx>, <linux-imx@xxxxxxx>, <cezary.rojewski@xxxxxxxxx>, <pierre-louis.bossart@xxxxxxxxxxxxxxx>, <peter.ujfalusi@xxxxxxxxxxxxxxx>, <yung-chuan.liao@xxxxxxxxxxxxxxx>, <ranjani.sridharan@xxxxxxxxxxxxxxx>, <kai.vehmanen@xxxxxxxxxxxxxxx>, <matthias.bgg@xxxxxxxxx>, <bgoswami@xxxxxxxxxxx>, <vkoul@xxxxxxxxxx>, <daniel.baluta@xxxxxxx>, <thierry.reding@xxxxxxxxx>, <jonathanh@xxxxxxxxxx>, <jarkko.nikula@xxxxxxxxxx>
- Subject: Re: [PATCH] ASoC: do not include pm_runtime.h if not used
- From: <Claudiu.Beznea@xxxxxxxxxxxxx>
- Date: Fri, 10 Mar 2023 08:12:16 +0000
- Cc: alsa-devel@xxxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, patches@xxxxxxxxxxxxxxxxxxxxx, linuxppc-dev@xxxxxxxxxxxxxxxx, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, linux-mediatek@xxxxxxxxxxxxxxxxxxx, sound-open-firmware@xxxxxxxxxxxxxxxx, linux-tegra@xxxxxxxxxxxxxxx, linux-omap@xxxxxxxxxxxxxxx
- In-reply-to: <ef92dcac-cadd-b85e-d6ea-512684266e81@linaro.org>
- References: <20230307103022.1007420-1-claudiu.beznea@microchip.com> <ef92dcac-cadd-b85e-d6ea-512684266e81@linaro.org>
- User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1
On 10.03.2023 09:29, Srinivas Kandagatla wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On 07/03/2023 10:30, Claudiu Beznea wrote: >> diff --git a/sound/soc/qcom/lpass-sc7180.c b/sound/soc/qcom/lpass-sc7180.c >> index 41db6617e2ed..dc892fac4baa 100644 >> --- a/sound/soc/qcom/lpass-sc7180.c >> +++ b/sound/soc/qcom/lpass-sc7180.c >> @@ -12,7 +12,6 @@ >> #include <linux/module.h> >> #include <linux/of.h> >> #include <linux/platform_device.h> >> -#include <linux/pm_runtime.h> >> #include <dt-bindings/sound/sc7180-lpass.h> >> #include <sound/pcm.h> >> #include <sound/soc.h> >> diff --git a/sound/soc/qcom/lpass-sc7280.c b/sound/soc/qcom/lpass-sc7280.c >> index d43f480cbae3..ee4a4b553e74 100644 >> --- a/sound/soc/qcom/lpass-sc7280.c >> +++ b/sound/soc/qcom/lpass-sc7280.c >> @@ -8,7 +8,6 @@ >> #include <linux/module.h> >> #include <sound/pcm.h> >> #include <sound/soc.h> >> -#include <linux/pm_runtime.h> >> >> #include <dt-bindings/sound/sc7180-lpass.h> > > Has these been compile tested? the reason I ask is because both these > drivers need SET_SYSTEM_SLEEP_PM_OPS macro from pm.h which was getting > included from pm_runtime.h, now that is removed, am guessing it will > cause a compile errors. I remember I compiled them all. But I will double check it. > > can you atleast replace this with pm.h instead of removing it totally? Sure! Thanks for pointing it. > > --srini
--- End Message ---
