Re: [PATCH] kselftest/alsa - mixer-test: Don't fail tests if we can't restore default

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 06 Mar 2023 15:20:03 +0100,
Mark Brown wrote:
> 
> If a control has an invalid default value then we might fail to set it
> when restoring the default value after our write tests, for example due to
> correctly implemented range checks in put() operations. Currently this
> causes us to report the tests we were running as failed even when the
> operation we were trying to test is successful, making it look like there
> are problems where none really exist. Stop doing this, only reporting any
> issues during the actual test.
> 
> We already have validation for the initial readback being in spec and for
> writing the default value back so failed tests will be reported for these
> controls, and we log an error on the operation that failed when we write so
> there will be a diagnostic warning the user that there is a problem.
> 
> Signed-off-by: Mark Brown <broonie@xxxxxxxxxx>

Applied to for-next branch.  Thanks.


Takashi



[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux