--- Begin Message ---
- To: Claudiu Beznea <claudiu.beznea@xxxxxxxxxxxxx>
- Subject: Re: [PATCH] ASoC: do not include pm_runtime.h if not used
- From: Charles Keepax <ckeepax@xxxxxxxxxxxxxxxxxxxxx>
- Date: Tue, 7 Mar 2023 11:30:16 +0000
- Cc: tiwai@xxxxxxxx, lgirdwood@xxxxxxxxx, broonie@xxxxxxxxxx, james.schulman@xxxxxxxxxx, david.rhodes@xxxxxxxxxx, tanureal@xxxxxxxxxxxxxxxxxxxxx, rf@xxxxxxxxxxxxxxxxxxxxx, oder_chiou@xxxxxxxxxxx, shengjiu.wang@xxxxxxxxx, Xiubo.Lee@xxxxxxxxx, festevam@xxxxxxxxx, nicoleotsuka@xxxxxxxxx, shawnguo@xxxxxxxxxx, s.hauer@xxxxxxxxxxxxxx, kernel@xxxxxxxxxxxxxx, linux-imx@xxxxxxx, cezary.rojewski@xxxxxxxxx, pierre-louis.bossart@xxxxxxxxxxxxxxx, peter.ujfalusi@xxxxxxxxxxxxxxx, yung-chuan.liao@xxxxxxxxxxxxxxx, ranjani.sridharan@xxxxxxxxxxxxxxx, kai.vehmanen@xxxxxxxxxxxxxxx, matthias.bgg@xxxxxxxxx, srinivas.kandagatla@xxxxxxxxxx, bgoswami@xxxxxxxxxxx, vkoul@xxxxxxxxxx, daniel.baluta@xxxxxxx, thierry.reding@xxxxxxxxx, jonathanh@xxxxxxxxxx, jarkko.nikula@xxxxxxxxxx, alsa-devel@xxxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, patches@xxxxxxxxxxxxxxxxxxxxx, linuxppc-dev@xxxxxxxxxxxxxxxx, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, linux-mediatek@xxxxxxxxxxxxxxxxxxx, sound-open-firmware@xxxxxxxxxxxxxxxx, linux-tegra@xxxxxxxxxxxxxxx, linux-omap@xxxxxxxxxxxxxxx
- In-reply-to: <20230307103022.1007420-1-claudiu.beznea@microchip.com>
- References: <20230307103022.1007420-1-claudiu.beznea@microchip.com>
- User-agent: Mutt/1.5.21 (2010-09-15)
On Tue, Mar 07, 2023 at 12:30:22PM +0200, Claudiu Beznea wrote:
> Do not include pm_runtime.h header in files where runtime PM support is
> not implemented.
>
> Signed-off-by: Claudiu Beznea <claudiu.beznea@xxxxxxxxxxxxx>
> ---
> sound/soc/codecs/cs35l45.h | 1 -
> diff --git a/sound/soc/codecs/cs35l45.h b/sound/soc/codecs/cs35l45.h
> index 53fe9d2b7b15..0555702eac03 100644
> --- a/sound/soc/codecs/cs35l45.h
> +++ b/sound/soc/codecs/cs35l45.h
> @@ -11,7 +11,6 @@
> #ifndef CS35L45_H
> #define CS35L45_H
>
> -#include <linux/pm_runtime.h>
> #include <linux/regmap.h>
> #include <linux/regulator/consumer.h>
>
cs35l45 does already make use of some functions from that header,
and more support is in the process of being upstreamed. So this
part should be dropped.
Thanks,
Charles
--- End Message ---