On Thu, Mar 02, 2023 at 02:31:14PM +0100, Krzysztof Kozlowski wrote:
> On 02/03/2023 12:55, richard.leitner@xxxxxxxxx wrote:
> > From: Richard Leitner <richard.leitner@xxxxxxxxxxx>
> >
> > Convert from max9867.txt to maxim,max9867.yaml and add missing
> > '#sound-dai-cells' property.
>
> Thank you for your patch. There is something to discuss/improve.
>
> Except wrong ID (and missing test):
>
> > +
> > +examples:
> > + - |
> > + &i2c {
> > + max9867: max9867@18 {
>
> Generic node names, so "codec" and drop the unused label.
Thanks for the review and feedback. I'll fix that in v2.
>
> Use 4 spaces for example indentation.
Ok. checkpatch.pl didn't complain about that so I thought this was
fine. Are there any other scripts/tools to check for correct formatting
of bindings?
>
> > + compatible = "maxim,max9867";
> > + #sound-dai-cells = <0>;
> > + reg = <0x18>;
>
> Best regards,
> Krzysztof
>
Thanks & regards;rl
