Re: [PATCH] ASoC: sam9g20ek: Disable capture unless building with microphone input

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 25.02.2023 23:48, Mark Brown wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> Without modification the AT91SAM9G20-EK has no capture support, none of the
> inputs of the CODEC are wired to anything to useful and there are no paths
> supporting loopback. Since the audio is clocked from the CODEC and the DAPM
> inputs are marked as unusable this means that capture will fail to transfer
> any data as the ADC path can't be powered up.
> 
> Flag this in the device description so apps don't see unusable capture
> support, guarded with the existing optional define for mic input.
> 
> Signed-off-by: Mark Brown <broonie@xxxxxxxxxx>

Reviewed-by: Claudiu Beznea <claudiu.beznea@xxxxxxxxxxxxx>


> ---
>  sound/soc/atmel/sam9g20_wm8731.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/sound/soc/atmel/sam9g20_wm8731.c b/sound/soc/atmel/sam9g20_wm8731.c
> index 1430642c8433..785b9d01d8af 100644
> --- a/sound/soc/atmel/sam9g20_wm8731.c
> +++ b/sound/soc/atmel/sam9g20_wm8731.c
> @@ -98,6 +98,9 @@ static struct snd_soc_dai_link at91sam9g20ek_dai = {
>         .init = at91sam9g20ek_wm8731_init,
>         .dai_fmt = SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_NB_NF |
>                    SND_SOC_DAIFMT_CBP_CFP,
> +#ifndef ENABLE_MIC_INPUT
> +       .playback_only = true,
> +#endif
>         SND_SOC_DAILINK_REG(pcm),
>  };
> 
> 
> ---
> base-commit: cac85e4616b1cf4a90844b952b49b9cbc4562530
> change-id: 20230225-asoc-sam9g20ek-f4e775205d8c
> 
> Best regards,
> --
> Mark Brown <broonie@xxxxxxxxxx>
> 





[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux