Re: [PATCH] ucm2: Rockchip: rk817: Add ALSA UCM support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 22. 02. 23 17:38, Chris Morgan wrote:
From: Chris Morgan <macromorgan@xxxxxxxxxxx>

Add ALSA-UCM support for the Rockchip RK817 audio codec. This codec
is typically configured either with an internal or external amplifier
as reflected by the longname. This configuration has been tested on
the Anbernic RG353P (rk817_ext) and the Odroid Go Advance (rk817_int).

Thank you for your contribution.

Signed-off-by: Chris Morgan <macromorgan@xxxxxxxxxxx>
---
  ucm2/Rockchip/rk817-sound/HiFi.conf        | 66 ++++++++++++++++++++++
  ucm2/Rockchip/rk817-sound/rk817-sound.conf |  7 +++
  ucm2/conf.d/simple-card/rk817_ext.conf     |  1 +
  ucm2/conf.d/simple-card/rk817_int.conf     |  1 +
  4 files changed, 75 insertions(+)
  create mode 100644 ucm2/Rockchip/rk817-sound/HiFi.conf
  create mode 100644 ucm2/Rockchip/rk817-sound/rk817-sound.conf
  create mode 120000 ucm2/conf.d/simple-card/rk817_ext.conf
  create mode 120000 ucm2/conf.d/simple-card/rk817_int.conf

diff --git a/ucm2/Rockchip/rk817-sound/HiFi.conf b/ucm2/Rockchip/rk817-sound/HiFi.conf
new file mode 100644
index 0000000..e285db7
--- /dev/null
+++ b/ucm2/Rockchip/rk817-sound/HiFi.conf
@@ -0,0 +1,66 @@
+If.1 {
+	Condition {
+		Type ControlExists
+		Control "name='Internal Speakers Switch'"
+	}
+
+	True {
+		SectionDevice."Speaker".EnableSequence [
+			cset "name='Playback Mux' HP"
+			cset "name='Internal Speakers Switch' on"
+		]

It would be better to use variable (Define) to set the "Playback Mux", because the [] arrays are stacked after evaluation in this case like:

SectionDevice."Speaker".EnableSequence [
	cset "name='Playback Mux' SPK"
	cset "name='Playback Mux' HP"
	cset "name='Internal Speakers Switch' on"
]

so

Define.pbk_mux "SPK"
.... If.1.True { Define.pbk_mux "HP" }
.... SectionDevice."Speaker".EnableSequence [
	cset "name='Playback Mux' ${var:pbk_mux}"
]

Otherwise a nice clean config.

			Thanks,
				Jaroslav

--
Jaroslav Kysela <perex@xxxxxxxx>
Linux Sound Maintainer; ALSA Project; Red Hat, Inc.




[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux