On 2/22/23 06:48, Richard Fitzgerald wrote:
> On 21/02/2023 16:52, Pierre-Louis Bossart wrote:
>>
>>> +static const struct snd_soc_acpi_link_adr
>>> up_extreme_cs35l56_sdw0_one[] = {
>>> + {
>>> + .mask = BIT(0),
>>> + .num_adr = 1,
>>> + .adr_d = cs35l56_sdw0_adr,
>>> + },
>>> + {}
>>> +};
>>> +
>>> +static const struct snd_soc_acpi_link_adr
>>> up_extreme_cs35l56_sdw0_four[] = {
>>> + {
>>> + .mask = BIT(0),
>>> + .num_adr = 4,
>>> + .adr_d = cs35l56_sdw0_adr,
>>> + },
>>> + {}
>>> +};
>>
>> If the machine driver has support for the 2-amplifier configuration,
>> shouldn't it be present here as well?
>>
>
> Not necessarily.
> It's not a setup we're currently using on this initial TGL
> configuration.
>
> The machine driver we'd expect to work on multiple hardware. The
> counting algorithm has to go through "2" anyway, and the code to
> handle that is so trivial we may as well include it.
it's fine. usually we are more conservative and have a 1:1 match between
the soc-acpi tables and machine driver, but it doesn't hurt to add the
2-amp case in the machine driver.
