On Wed, Feb 22, 2023 at 07:39:45PM +0800, Chancel Liu wrote:
> + switch (cmd) {
> + case SNDRV_PCM_TRIGGER_START:
> + case SNDRV_PCM_TRIGGER_RESUME:
> + case SNDRV_PCM_TRIGGER_PAUSE_RELEASE:
> + mdelay(wm8524->power_up_delay);
> + break;
Doing a 100ms busy wait in atomic context does not seem like a great
idea, never mind a 1.5s one. This shouldn't be done in trigger, it
needs to be done later - digital_mute() might be a better time to hook
in, though longer delays like this are really quite bad.
Attachment:
signature.asc
Description: PGP signature
