On Tue, Feb 14, 2023 at 03:02:02PM +0000, Mark Brown wrote: > On Tue, Feb 14, 2023 at 03:26:14PM +0100, Alexander Sverdlin wrote: > > On Tue, 2023-02-14 at 15:11 +0100, Krzysztof Kozlowski wrote: > > > > OK, but then I like the example - if datasheet would use name > > > "clk_clk_this_is_clk" would you still find it meaningful? > > > > Every clock input in clocks is a clock. There is usually no need to say > > > that a clock is a clock... > > > I see you point, but this is legacy code (sound/soc/cirrus/ep93xx-i2s.c) > > which took these names back in platform data times... I also see that > > rather majority of *i2s*.yaml use something "*clk", so maybe it could > > be accepted for legacy code? > > Even ignoring the whole legacy thing these are industry standard > names for the clocks - they are pretty much universally named and > referred to with the clk suffix. I can't see what removing it > would accomplish other than reducing clarity. Agreed. If a clock is called "Nclk" then I think that is fine. If it is foo_bar_clk, then yes, 'foo_bar' is preferred. Rob
