On 14/02/23 19:03, Pierre-Louis Bossart wrote: > >>>> +/* AMD pm_runtime quirk definitions */ >>>> + >>>> +/* >>>> + * Force the clock to stop(ClockStopMode0) when suspend callback >>>> + * is invoked. >>>> + */ >>>> +#define AMD_SDW_CLK_STOP_MODE 1 >>>> + >>>> +/* >>>> + * Stop the bus when runtime suspend/system level suspend callback >>>> + * is invoked. If set, a complete bus reset and re-enumeration will >>>> + * be performed when the bus restarts. >>>> + */ >>>> +#define AMD_SDW_POWER_OFF_MODE 2 >>> You need to clarify this mode, can you deal with device in-band wakes if >>> the power is off? >> On the Current platform, in-band wakes are not supported if the power is off. > Humm, that's an important clarification. > > Does this mean your link0 will never use the POWER_OFF_MODE since it > includes support for headset codecs and you want the ability to detect > jacks status changes? Yes. we will use CLK_STOP_MODE in runtime pm and system suspend for Link0 when jack codec is connected over Link 0. > > Or is this more like CLK_STOP_MODE is used in runtime pm and POWER_OFF > in system suspend?
