On Fri, 10 Feb 2023 17:55:41 +0100,
Cezary Rojewski wrote:
>
> Commit f2bd1c5ae2cb ("ALSA: hda: Fix page fault in
> snd_hda_codec_shutdown()") relocated initialization of several codec
> device fields. Due to differences between codec_exec_verb() and
> snd_hdac_bus_exec_bus() in how they handle VERB execution - the latter
> does not touch PM - assigning ->exec_verb to codec_exec_verb() causes PM
> to be engaged before it is configured for the device. Configuration of
> PM for the ASoC HDAudio sound card is done with snd_hda_set_power_save()
> during skl_hda_audio_probe() whereas the assignment happens early, in
> snd_hda_codec_device_init().
>
> Revert to previous behavior to avoid problems caused by too early PM
> manipulation.
>
> Suggested-by: Jason Montleon <jmontleo@xxxxxxxxxx>
> Link: https://lore.kernel.org/regressions/CALFERdzKUodLsm6=Ub3g2+PxpNpPtPq3bGBLbff=eZr9_S=YVA@xxxxxxxxxxxxxx
> Fixes: f2bd1c5ae2cb ("ALSA: hda: Fix page fault in snd_hda_codec_shutdown()")
> Signed-off-by: Cezary Rojewski <cezary.rojewski@xxxxxxxxx>
> ---
>
> A result of recent discussion [1] regarding sound regression in v6.1 and
> onward. Fix made possible by outstanding input from Jason and Sasa
> (Cced) - Thank you!
>
> Note: I did not receive results from our CI yet, should happen on Monday
> but posting early so the review can be conducted.
>
> [1]: https://lore.kernel.org/regressions/CALFERdzKUodLsm6=Ub3g2+PxpNpPtPq3bGBLbff=eZr9_S=YVA@xxxxxxxxxxxxxx/
Applied now. Thanks.
Takashi
