Hi Morimoto-san,
On Fri, Feb 10, 2023 at 1:22 AM Kuninori Morimoto
<kuninori.morimoto.gx@xxxxxxxxxxx> wrote:
> > > From: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx>
> > >
> > > There are no compatible for "reg/reg-names" and "clock-name"
> > > between previous R-Car series and R-Car Gen4.
> > >
> > > "reg/reg-names" needs 3 categorize (for Gen1, for Gen2/Gen3, for Gen4),
> > > therefore, use 3 if-then to avoid nested if-then-else.
> > >
> > > Move "clock-name" property to under allOf to use if-then-else.
> (snip)
> > > - clock-names:
> > > - description: List of necessary clock names.
> > > - minItems: 1
> > > - maxItems: 31
> >
> > No improvements here. Your argument that you need to remove it to
> > customize is not correct.
>
> ???
>
> Move "clock-name" property to under allOf to use if-then-else.
> ^^^^
>
> "move", not "remove".
The point is that you did remove the common
clock-names:
description: List of necessary clock names.
from the top level, and added two copies of it under if/then/else.
Please keep common stuff as high up in the hierarchy as possible,
to avoid the need for duplication.
In this case, that means:
- Keep the description at the top level,
- Put only {min,max}Items and items under if/then/else.
I hope my explanation helps.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
