Re: [PATCH 2/2] ASoC: dt-bindings: renesas,rsnd.yaml: adjust to R-Car Gen4

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Krzysztof

> Do not use "This commit/patch".
(snip)
> Same below.

OK, will fix in v2 patch

> > Link: https://lore.kernel.org/r/CAMuHMdW_QHmODAKvn_GwHHUWw-=z4Tdq0NkhdK2u2piG_YgB-Q@xxxxxxxxxxxxxx
> > Link: https://lore.kernel.org/all/87zg9vk0ex.wl-kuninori.morimoto.gx@xxxxxxxxxxx/#r
> > Link: https://lore.kernel.org/all/87r0v2uvm7.wl-kuninori.morimoto.gx@xxxxxxxxxxx/#r
> > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx>
(snip)
> You gave three links, so why? You should rather explain why it does not
> work.

In my understanding, "Link:" is used to indicates what kind of discussion
have been done in ML, etc. Above are the link to related to this patch.

And I'm not sure why it doesn't work, it is the problem.

> > -  clock-names:
> > -    description: List of necessary clock names.
> > -    minItems: 1
> > -    maxItems: 31
> 
> Don't remove properties from top-level.

It needs if-then-else, So it moved to bottom side,
not removed.

> > @@ -256,8 +242,6 @@ properties:
> >              $ref: /schemas/types.yaml#/definitions/flag
> >          required:
> >            - interrupts
> > -          - dmas
> > -          - dma-names
> 
> Even with your explanation in commit this does not look related to this
> patch. Don't mix features and fixes.

Hmm.. indeed.
Will fix in v2


Thank you for your help !!

Best regards
---
Kuninori Morimoto



[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux