On Fri 03 Feb 2023 at 18:59, Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> wrote: > On 03/02/2023 15:13, Jerome Brunet wrote: >>>> + Multiplication factor between the frame rate and master clock >>>> + rate >>>> + >>>> + sound-dai: >>>> + $ref: /schemas/types.yaml#/definitions/phandle-array >>> >>> Old binding was saying it is just phandle >> >> It is just a phandle but the bindings used to have problem with phandle >> that had cells. >> >> See: >> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/Documentation/devicetree/bindings/sound/amlogic,gx-sound-card.yaml?h=v6.2-rc6&id=d031d99b02eaf7363c33f5b27b38086cc8104082 >> >> Was it wrong or did the situation change since then ? > > Then define it as having cells: > > https://elixir.bootlin.com/linux/v5.18-rc1/source/Documentation/devicetree/bindings/soc/samsung/exynos-usi.yaml#L42 > The card is provided with the phandle. Whether or not the phandle has cells or not has nothing do with card driver. The card just consums sound-dai. I don't understand this comment. > > Best regards, > Krzysztof
