On 03/02/2023 06:06, Ki-Seok Jo wrote: >>>>> + sys-clk-id: >>>>> + description: select the using system clock. >>>> >>>> What does it mean? Why do you need such property instead of clocks? >>> >>> This can receive an external clock, but it can use internal clock. >>> Should I write all the clock descriptions in case? >> >> How do you configure and enable external clock with this property? I don't >> see it. If the device has clock input, this should be "clocks". If it is >> omitted, then internal clock is used. >> > > Basically, this value is set with set_sysclk in the dai operations. > So, I also get the clk_id from this function and set it. > From the point of view of the codec driver, there are case where the machine > driver does not give this value(clk_id). It's entirely different discussion. You did not document the clocks/values for it and just wrote "select the using", so like a "bool" property. You need bindings documenting the clocks. Use the same name as here: https://lore.kernel.org/all/20221022162742.21671-2-aidanmacdonald.0x0@xxxxxxxxx/ Best regards, Krzysztof
